Skip to content

ITS3: Fix matrix generation in helper class #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 5 commits into from
Apr 10, 2025
Merged

ITS3: Fix matrix generation in helper class #13895

shahor02 merged 5 commits into from
Apr 10, 2025

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jan 23, 2025 •
edited
Loading

Fixes a wrong y-local offset for ITS3 sensors.
Also I removed and demoted some logging to debug about the layer composition.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch f3sch closed this Jan 29, 2025
@f3sch f3sch deleted the its3/matrix_gen branch January 29, 2025 14:50
@f3sch f3sch restored the its3/matrix_gen branch January 29, 2025 14:56
@f3sch f3sch reopened this Jan 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch f3sch mentioned this pull request Feb 3, 2025
Merged
@f3sch
ITS: change layer name to debug severity
68366d2 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions github-actions bot added the stale label Mar 6, 2025
@f3sch f3sch removed the stale label Mar 6, 2025
@AliceO2Group AliceO2Group deleted a comment from github-actions bot Mar 6, 2025
@f3sch f3sch marked this pull request as ready for review April 2, 2025 09:42
@f3sch f3sch force-pushed the its3/matrix_gen branch from d141b7a to fe79f54 Compare April 2, 2025 11:53
f3sch added 3 commits April 2, 2025 13:57
@f3sch
ITS: ITS3 matrix generation fix + demoting&removal of logging
c57f33b 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Propagate rename to ITS helper class
7511c95 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: make ITSRESPONSE cached var
543e4d9 
Allows reusing this variable later on.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch force-pushed the its3/matrix_gen branch from fe79f54 to 00c9c53 Compare April 2, 2025 11:57
@alibuild
Copy link
Collaborator

alibuild commented Apr 2, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 00c9c53 at 2025-04-03 00:10:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile digi.log
./sim-challenge.logdigi.log:[5669:internal-dpl-ccdb-backend]: [00:10:04][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logdigi.log-[5669:internal-dpl-ccdb-backend]: [00:10:04][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./sim-challenge.log[5671:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./sim-challenge.log[5663:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./sim-challenge.log[5663:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./sim-challenge.log[5663:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./sim-challenge.log[5663:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
[0 more errors; see full log]

Full log here.

@f3sch f3sch enabled auto-merge (rebase) April 4, 2025 07:31
@f3sch f3sch mentioned this pull request Apr 4, 2025
Merged
@f3sch
Copy link
Collaborator Author

f3sch commented Apr 7, 2025

Hi @shahor02 or @fprino this is ready from my side, could you please review and or merge?

shahor02
shahor02 requested changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @f3sch

Just 1 comment below, otherwise fine for me.

@f3sch f3sch force-pushed the its3/matrix_gen branch from 00c9c53 to 26582a6 Compare April 7, 2025 11:36
@f3sch
ITS: digiparams make print func virtual
c0333ff 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch force-pushed the its3/matrix_gen branch from 26582a6 to c0333ff Compare April 7, 2025 11:40
@shahor02
Copy link
Collaborator

shahor02 commented Apr 7, 2025

Well, the version number increase is needed only if a new data member is added.

@f3sch f3sch requested a review from shahor02 April 8, 2025 11:12
@alibuild
Copy link
Collaborator

alibuild commented Apr 9, 2025

Error while checking build/O2/fullCI_slc9 for c0333ff at 2025-04-09 09:42:

## sw/BUILD/SHERPA-latest/log
configure: error: Sqlite3 required but not found.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Apr 10, 2025

@shahor02 the failure is unrelated and was green before, could this please be merged?

@shahor02 shahor02 merged commit fcdf98d into AliceO2Group:dev Apr 10, 2025
10 of 11 checks passed
@f3sch f3sch deleted the its3/matrix_gen branch April 10, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fprino fprino Awaiting requested review from fprino fprino is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f3sch @alibuild @shahor02