chore: Update runners in make-release workflow #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the OS matrix in the make_release GitHub Actions workflow to run separate jobs on macOS 15 Intel and generic macOS 15 runners instead of macOS 13 and 14. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
📝 WalkthroughWalkthroughGitHub Actions workflow configuration updated to replace macOS runners macos-13 and macos-14 with macos-15-intel and macos-15 in the build matrix for PyInstaller bundle creation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/make_release.yml (1)
31-53:compile numpy on macos-14step is now unreachable (matrix no longer includesmacos-14).
If you still need the numpy source-build workaround, retarget it to the appropriate new macOS runner(s); otherwise remove the step to avoid misleading CI configuration.Proposed fix (retarget to intel runner; adjust if you meant arm runner too)
- - name: compile numpy on macos-14 - if: ${{ matrix.os == 'macos-14' }} + - name: compile numpy (source) on macos-15-intel + if: ${{ matrix.os == 'macos-15-intel' }} run: | python -m pip install --no-binary numpy numpy --force-reinstall --constraint requirements/constraints_py3.12.txt
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/make_release.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: Czaki
Repo: 4DNucleome/PartSeg PR: 1261
File: .github/workflows/test_napari_widgets.yml:48-48
Timestamp: 2025-05-04T12:34:58.306Z
Learning: GitHub Actions supports ubuntu-24.04 as a runner option since May 2024 (beta) and July 2024 (GA). It can be used in workflows by specifying `ubuntu-24.04` in the `runs-on` parameter. As of May 2025, `ubuntu-latest` also points to Ubuntu 24.04.
Learnt from: Czaki
Repo: 4DNucleome/PartSeg PR: 1261
File: .github/workflows/test_napari_widgets.yml:48-48
Timestamp: 2025-05-04T12:34:58.306Z
Learning: GitHub Actions supports ubuntu-24.04 as a runner option as of April 2024 when Ubuntu 24.04 LTS (Noble Numbat) was released. This is in addition to other supported Ubuntu versions like ubuntu-22.04 and ubuntu-latest.
📚 Learning: 2025-05-04T12:34:58.306Z
Learnt from: Czaki
Repo: 4DNucleome/PartSeg PR: 1261
File: .github/workflows/test_napari_widgets.yml:48-48
Timestamp: 2025-05-04T12:34:58.306Z
Learning: GitHub Actions supports ubuntu-24.04 as a runner option since May 2024 (beta) and July 2024 (GA). It can be used in workflows by specifying `ubuntu-24.04` in the `runs-on` parameter. As of May 2025, `ubuntu-latest` also points to Ubuntu 24.04.
Applied to files:
.github/workflows/make_release.yml
📚 Learning: 2025-05-04T12:34:58.306Z
Learnt from: Czaki
Repo: 4DNucleome/PartSeg PR: 1261
File: .github/workflows/test_napari_widgets.yml:48-48
Timestamp: 2025-05-04T12:34:58.306Z
Learning: GitHub Actions supports ubuntu-24.04 as a runner option as of April 2024 when Ubuntu 24.04 LTS (Noble Numbat) was released. This is in addition to other supported Ubuntu versions like ubuntu-22.04 and ubuntu-latest.
Applied to files:
.github/workflows/make_release.yml
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: Prepare coverage
- GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
- GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
- GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
- GitHub Check: 4DNucleome.PartSeg (Builds sdist)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
- GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
- GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
- GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Sourcery review
🔇 Additional comments (1)
.github/workflows/make_release.yml (1)
28-33: Ensure PyInstaller build targets match the runner architectures.The runner labels
macos-15(Apple Silicon / arm64) andmacos-15-intel(Intel / x86_64) are supported GitHub Actions runner labels. Verify that your build process correctly targets both architectures via the matrix—in particular, that the PyInstaller artifacts produced on each runner match your intended distribution targets (arm64 builds frommacos-15, x86_64 builds frommacos-15-intel).
Czaki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.