Skip to content

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Jan 12, 2026

Summary by Sourcery

CI:

  • Remove the macOS-14 numpy force-recompile step from the release GitHub Actions workflow.

Summary by CodeRabbit

  • Chores
    • Streamlined the macOS release build by removing a redundant NumPy compilation step, shortening the macOS build path.
    • Standardized package naming by updating "numpy" to "NumPy" in project metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the GitHub Actions release workflow by removing a macOS-specific step that forcibly recompiles NumPy before building the executable bundle.

File-Level Changes

Change Details Files
Simplify the release workflow by dropping the macOS-14 NumPy recompilation step before building the executable.
  • Remove the conditional job step that runs only on macos-14.
  • Stop force-reinstalling NumPy from source with --no-binary and constraints before the bundle build step.
  • Keep the editable PartSeg installation and bundle build steps unchanged.
.github/workflows/make_release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Removed a macOS-specific step that compiled NumPy from source on the macos-14 runner and renamed a project dictionary entry from numpy to NumPy; no other functional changes.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/make_release.yml
Deleted the conditional macos-14 step that forced pip install --no-binary :all: numpy and its associated matrix condition (5 lines removed).
Project Dictionary
.github/project_dict.pws
Renamed list entry from numpy to NumPy (case change, +1/-1 lines).

Sequence Diagram(s)

(omitted — changes are minor workflow and metadata edits and do not introduce new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

skip check PR title

Poem

🐰 I hopped through CI with nimble paws,
One fewer step, fewer build-time laws.
NumPy's name now capital and neat,
CI hops lighter on springy feet.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing a NumPy compilation workaround for macOS in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f0ecf5 and ea7bc75.

📒 Files selected for processing (1)
  • .github/project_dict.pws
✅ Files skipped from review due to trivial changes (1)
  • .github/project_dict.pws
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: Prepare coverage
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
  • GitHub Check: 4DNucleome.PartSeg (Builds sdist)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
  • GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
  • GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
  • GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
  • GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Sourcery review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If the macos-14-specific numpy compile step is no longer needed due to upstream wheel availability or other fixes, consider adding a short comment in the workflow or PR description explaining why it’s safe to remove to help future maintainers understand the context.
  • Now that the macos-14 special-case step is gone, review the workflow matrix and any remaining macos-14 conditionals to see if there’s further simplification or consolidation possible in the CI configuration.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If the macos-14-specific numpy compile step is no longer needed due to upstream wheel availability or other fixes, consider adding a short comment in the workflow or PR description explaining why it’s safe to remove to help future maintainers understand the context.
- Now that the macos-14 special-case step is gone, review the workflow matrix and any remaining macos-14 conditionals to see if there’s further simplification or consolidation possible in the CI configuration.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (a68f0a5) to head (ea7bc75).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1345   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files          210      210           
  Lines        33251    33251           
========================================
  Hits         30981    30981           
  Misses        2270     2270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki changed the title chore: Remove numpy hack fo build executable on macos chore: Remove NumPy hack for building executable on macOS Jan 12, 2026
@sonarqubecloud
Copy link

@Czaki Czaki added this to the 0.16.5 milestone Jan 12, 2026
@Czaki Czaki merged commit af4d50b into develop Jan 12, 2026
64 checks passed
@Czaki Czaki deleted the remove_obsolete_steep branch January 12, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants