-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Remove NumPy hack for building executable on macOS #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the GitHub Actions release workflow by removing a macOS-specific step that forcibly recompiles NumPy before building the executable bundle. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
📝 WalkthroughWalkthroughRemoved a macOS-specific step that compiled NumPy from source on the macos-14 runner and renamed a project dictionary entry from Changes
Sequence Diagram(s)(omitted — changes are minor workflow and metadata edits and do not introduce new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- If the macos-14-specific numpy compile step is no longer needed due to upstream wheel availability or other fixes, consider adding a short comment in the workflow or PR description explaining why it’s safe to remove to help future maintainers understand the context.
- Now that the macos-14 special-case step is gone, review the workflow matrix and any remaining macos-14 conditionals to see if there’s further simplification or consolidation possible in the CI configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the macos-14-specific numpy compile step is no longer needed due to upstream wheel availability or other fixes, consider adding a short comment in the workflow or PR description explaining why it’s safe to remove to help future maintainers understand the context.
- Now that the macos-14 special-case step is gone, review the workflow matrix and any remaining macos-14 conditionals to see if there’s further simplification or consolidation possible in the CI configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1345 +/- ##
========================================
Coverage 93.17% 93.17%
========================================
Files 210 210
Lines 33251 33251
========================================
Hits 30981 30981
Misses 2270 2270 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Summary by Sourcery
CI:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.