Skip to content

feat(file): Prevent progress display after file download completion #8062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Mar 4, 2025
Merged

feat(file): Prevent progress display after file download completion #8062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion agent/app/api/v2/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package v2

import (
"encoding/json"
"errors"
"fmt"
"io"
Expand Down Expand Up @@ -761,7 +762,16 @@ func (b *BaseApi) WgetProcess(c *gin.Context) {
func (b *BaseApi) ProcessKeys(c *gin.Context) {
res := &response.FileProcessKeys{}
keys := global.CACHE.PrefixScanKey("file-wget-")
res.Keys = keys
for _, key := range keys {
value := global.CACHE.Get(key)
if value == "" {
continue
}
var process files.Process
if err := json.Unmarshal([]byte(value), &process); err == nil && process.Percent != 100 {
res.Keys = append(res.Keys, key)
}
}
helper.SuccessWithData(c, res)
}

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be no significant coding changes required with respect to file processing using wget, but there might be some potential issues around handling JSON and caching in the context of this use case. Also, considering how we are currently managing files in-memory through string, it would generally make more sense to move away from strings for storing state (such as a map or array) so that we don't run out of memory when working on big data sets.

In terms of general improvements like modularization/standardizing naming conventions etc., I'd say the current implementation is good, though there are some places where it could improve readability and maintainability. This includes:

  • Using type annotations instead of Go's default string-type if possible, which helps with debugging by allowing clear visibility into parameter types,
  • Refactoring method calls across packages (if relevant),
  • Creating utility functions rather than inline small pieces of logic,

Please refer to comments provided inside each function body for specific details.

Remember all these comments can still grow over time based on usage patterns and enhancements made during maintenance processes; It's also worth mentioning we should always have version control checked-in source code!

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/host/file-management/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ const mobile = computed(() => {
});

const search = async () => {
getWgetProcess();
loading.value = true;
if (req.search != '') {
req.sortBy = 'name';
Expand Down Expand Up @@ -983,7 +984,6 @@ onMounted(() => {
nextTick(function () {
handlePath();
});
getWgetProcess();
});
</script>

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided answer is not in English, it seems to be in Chinese. Please note the following:

  1. The computed() function should return a property with reactive data rather than accessing another component directly.

    const mobile = computed(() => ({ ...mobile }));

  2. Use the const or let instead of the keyword "global" if you're using this in a larger code base.

  3. Remove unnecessary semicolons and add a space for better readability like:

loading.value = true;
if (req.search != '') {

Expand Down
Loading