Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds .NET 10 support to the System.Linq.Dynamic.Core library, upgrading the main test project to target net10.0 while maintaining backward compatibility with earlier versions. The changes also include updates to the Newtonsoft.Json package and introduce new projects for Entity Framework Core 10 support.
Key Changes:
- Adds net10.0 to target frameworks and creates new EFCore10 and console app projects
- Updates Newtonsoft.Json from version 13.0.3 to 13.0.4 across all projects
- Introduces a new test project for .NET 9 to maintain separate test coverage
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.Tests/System.Linq.Dynamic.Core.Tests.csproj | Updates main test project target framework from net9.0 to net10.0 and Newtonsoft.Json to 13.0.4 |
| test/System.Linq.Dynamic.Core.Tests.Net9/System.Linq.Dynamic.Core.Tests.Net9.csproj | Adds new test project targeting net9.0 to maintain test coverage for that framework |
| test/System.Linq.Dynamic.Core.Tests.Net8/System.Linq.Dynamic.Core.Tests.Net8.csproj | Corrects EFCore project reference from EFCore7 to EFCore8 and updates Newtonsoft.Json |
| test/System.Linq.Dynamic.Core.Tests.Net[5-7,CoreApp31]/**.csproj | Updates Newtonsoft.Json to 13.0.4 across older test projects |
| test/EntityFramework.DynamicLinq.Tests/EntityFramework.DynamicLinq.Tests.csproj | Updates Newtonsoft.Json to 13.0.4 |
| src/System.Linq.Dynamic.Core/System.Linq.Dynamic.Core.csproj | Adds net10.0 to target frameworks and includes net9.0 in ASYNCENUMERABLE condition |
| src/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore10/** | Creates new EFCore10 support project with net10.0 target framework |
| src-console/ConsoleApp_net10/** | Adds new console application for testing net10.0 functionality |
| src-console/ConsoleApp[EF*]/** | Updates Newtonsoft.Json to 13.0.4 across console applications |
| System.Linq.Dynamic.Core.sln | Updates Visual Studio version to 18 and adds new projects to solution |
| .github/workflows/ci.yml | Updates CI workflow to use .NET 10.0 SDK and updates test job name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...FrameworkCore.DynamicLinq.EFCore10/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore10.csproj
Outdated
Show resolved
Hide resolved
…ft.EntityFrameworkCore.DynamicLinq.EFCore10.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Nov 17, 2025
This was referenced Dec 1, 2025
This was referenced Dec 15, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.