Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef09e1a3bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let fetch = | ||
| RescriptRelay_Query.fetch ~convertResponse ~convertVariables | ||
| RescriptRelay_Query.fetch_ ~convertResponse ~convertVariables | ||
| ~node:[%e valFromGeneratedModule ["node"]]]; |
There was a problem hiding this comment.
fetch helper from generated query modules
In the default React mode, the PPX now generates RescriptRelay_Query.fetch_ here, but packages/rescript-relay/src/RescriptRelay_Query.resi still only exposes fetch. Downstream [%relay.query] artifacts will therefore reference a symbol that is not in the published interface and fail to type-check as soon as a consumer upgrades to this PPX/runtime pair.
Useful? React with 👍 / 👎.
| let fetch_ = ( | ||
| ~node, | ||
| ~convertResponse: 'response => 'response, | ||
| ~convertVariables: 'variables => 'variables, |
There was a problem hiding this comment.
RescriptRelay_QueryNonReact.fetch as a public export
This file has no .resi, and packages/rescript-relay/package.json exports ./src/*, so renaming the top-level binding from fetch to fetch_ is a breaking API change for anyone importing the non-React runtime directly. Existing callers of RescriptRelay_QueryNonReact.fetch will stop compiling (ReScript) or start getting undefined (JS) after upgrading.
Useful? React with 👍 / 👎.
1 participant
No description provided.