Skip to content

docs: clarify iOS/Android are unsupported due to no window close event #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs: clarify iOS/Android are unsupported due to no window close event #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dee813
Initial plan
Copilot Mar 12, 2026
d6be508
docs: update copilot-instructions.md with iOS/Android non-support reason
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ All desktop methods guard against web usage with `if (kIsWeb) throw Exception(..
- **Swift (macOS):** Standard Swift style; `//MARK: -` comment separators for protocol sections.
- **C++ (Windows/Linux):** Google-style C++; `snake_case` for variables and methods; braces on same line; use `std::optional<LRESULT>` for the Windows proc delegate return type.
- **Naming:** Plugin class is `FlutterWindowClosePlugin` on all platforms; channel names are string literals, not constants, and must match exactly across Dart and native.
- **No mobile support:** Do not add iOS or Android platform entries. The plugin intentionally targets desktop and web only.
- **No mobile support:** Do not add iOS or Android platform entries. iOS and Android do not have a window close event, so this plugin cannot be supported on those platforms. The plugin intentionally targets desktop (macOS, Windows, Linux) and web only.

---

Expand Down Expand Up @@ -150,7 +150,7 @@ When adding new native files, update the relevant `CMakeLists.txt` (Windows/Linu

## Adding a New Platform

1. Add a native implementation in a new top-level directory (e.g., `ios/`).
1. Add a native implementation in a new top-level directory (e.g., `my_platform/`).
2. Register the plugin class in `pubspec.yaml` under `flutter.plugin.platforms`.
3. Implement the two method channels (`flutter_window_close` for commands, `flutter_window_close_notification` for events).
4. Guard any Dart-side platform-specific helpers with `defaultTargetPlatform` or `kIsWeb`.
Expand Down
Loading