Abort Censys annotation if we run out of credits#81
Open
phillip-stephens wants to merge 2 commits intomainfrom
Open
Abort Censys annotation if we run out of credits#81phillip-stephens wants to merge 2 commits intomainfrom
phillip-stephens wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we only logged the error if Censys returned a non-200 status code and then continued. Especially in cases like API token exhaustion, this would lead to a case where annotations at the start would work correctly and then silently fail.
This PR changes it so any 4XX error will abort the annotation. 500 is listed as a transient server error so those are just logged and we continue.
Specific HTTP statuses I've seen are:
422 Example
401 Example
200 Example