Various fixes #37
Merged
Various fixes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `handleExpandCollapse` method checks whether the collapsable element is responsive. If it is, the method proceeds only if the media query matches.
The `dataset.collapsableState` is modified only when `CollapsableEvent`s are associated with the expanding or collapsing elements. This ensures that events from nested collapsable elements do not affect the `dataset.collapsableState` further up the DOM tree.
On destroy, the `dataset.collapsableState` is removed from boxes, and the `role` attribute is removed from `extLink`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handleExpandCollapsemethod checks whether the collapsable element is responsive. If it is, the method proceeds only if the media query matches.The
dataset.collapsableStateis modified only whenCollapsableEvents are associated with the expanding or collapsing elements. This ensures that events from nested collapsable elements do not affect thedataset.collapsableStatefurther up the DOM tree.On destroy, the
dataset.collapsableStateis removed from boxes, and theroleattribute is removed fromextLink.