Skip to content

fix(qdrant) : pass timeout parameter to query_points in Qdrant clients#725

Open
Goodnight77 wants to merge 1 commit intozilliztech:mainfrom
Goodnight77:fix/qdrant-query-points-timeout
Open

fix(qdrant) : pass timeout parameter to query_points in Qdrant clients#725
Goodnight77 wants to merge 1 commit intozilliztech:mainfrom
Goodnight77:fix/qdrant-query-points-timeout

Conversation

@Goodnight77
Copy link

fix: pass timeout parameter to query_points in Qdrant clients

The search_embedding method in both qdrant clients (cloud and local) accepted a timeout parameter but didn't pass it to the underlying query_points call. This fix ensures the timeout is properly propagated

without the fix : when you call the search_embeddings( .. , timeout= 20) the timeout is ignored and it always uses default timeout (None)
with the fix : the timeout you specify is actually used (control how long to wait for searches )

Copilot AI review requested due to automatic review settings February 15, 2026 21:32
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Goodnight77
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug where the timeout parameter in the search_embedding method of both Qdrant clients (local and cloud) was accepted but not passed to the underlying query_points API call, causing it to be ignored.

Changes:

  • Added timeout parameter to query_points call in QdrantLocal client
  • Added timeout parameter to query_points call in QdrantCloud client

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vectordb_bench/backend/clients/qdrant_local/qdrant_local.py Passes timeout parameter to query_points in search_embedding method
vectordb_bench/backend/clients/qdrant_cloud/qdrant_cloud.py Passes timeout parameter to query_points in search_embedding method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants