fix(qdrant) : pass timeout parameter to query_points in Qdrant clients#725
fix(qdrant) : pass timeout parameter to query_points in Qdrant clients#725Goodnight77 wants to merge 1 commit intozilliztech:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Goodnight77 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where the timeout parameter in the search_embedding method of both Qdrant clients (local and cloud) was accepted but not passed to the underlying query_points API call, causing it to be ignored.
Changes:
- Added
timeoutparameter toquery_pointscall in QdrantLocal client - Added
timeoutparameter toquery_pointscall in QdrantCloud client
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vectordb_bench/backend/clients/qdrant_local/qdrant_local.py | Passes timeout parameter to query_points in search_embedding method |
| vectordb_bench/backend/clients/qdrant_cloud/qdrant_cloud.py | Passes timeout parameter to query_points in search_embedding method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: pass timeout parameter to query_points in Qdrant clients
The search_embedding method in both qdrant clients (cloud and local) accepted a timeout parameter but didn't pass it to the underlying query_points call. This fix ensures the timeout is properly propagated
without the fix : when you call the search_embeddings( .. , timeout= 20) the timeout is ignored and it always uses default timeout (None)
with the fix : the timeout you specify is actually used (control how long to wait for searches )