Skip to content

perf: optimize above-fold image loading [closes #332] #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zigzagdev wants to merge 3 commits into from
Closed

perf: optimize above-fold image loading [closes #332] #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fad9ee
perf(card): add isPriority prop — eager loading and fetchpriority for…
zigzagdev May 21, 2026
84bd1c8
perf(list): pass isPriority to first 3 cards in HeritageList
zigzagdev May 21, 2026
eec7294
perf(search): pass isPriority to first 3 cards in SearchResultsPage
zigzagdev May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/app/features/search/components/SearchResultsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ export default function SearchResultsPage({
</div>
) : (
<ul className="grid list-none grid-cols-1 gap-6 p-0 md:grid-cols-2 lg:grid-cols-3">
{items.map((it) => (
{items.map((it, index) => (
<li key={it.id} className="list-none">
<HeritageCard item={it} onClickItem={onClickItem} />
<HeritageCard item={it} onClickItem={onClickItem} isPriority={index < 3} />
</li>
))}
</ul>
Expand Down
8 changes: 7 additions & 1 deletion client/src/app/features/top/cards/HeritageCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ import { useText } from "@shared/locale/ui-text.ts";
export function HeritageCard({
item,
onClickItem,
isPriority = false,
}: {
item: WorldHeritageVm;
onClickItem?: (id: number) => void;
isPriority?: boolean;
}) {
const text = useText();

Expand All @@ -25,7 +27,11 @@ export function HeritageCard({
src={item.thumbnailUrl}
alt={title}
referrerPolicy="no-referrer"
loading="lazy"
loading={isPriority ? "eager" : "lazy"}
fetchPriority={isPriority ? "high" : "auto"}
decoding="async"
width={400}
height={320}
className="h-full w-full object-cover transition-transform duration-300 group-hover:scale-105"
/>
) : (
Expand Down
4 changes: 2 additions & 2 deletions client/src/app/features/top/components/HeritageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ export function HeritageList({

return (
<ul className="grid list-none grid-cols-1 gap-6 p-0 md:grid-cols-2 lg:grid-cols-3">
{items.map((it) => (
{items.map((it, index) => (
<li key={it.id} className="list-none">
<HeritageCard item={it} onClickItem={onClickItem} />
<HeritageCard item={it} onClickItem={onClickItem} isPriority={index < 3} />
</li>
))}
</ul>
Expand Down
Loading