replace callback based ast iterators with pollable iterators and walker #2576
+1,015
−1,003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KurtWagner
reviewed
Jan 18, 2026
Comment on lines
+1388
to
+1390
| const result = array[0].unwrap() orelse return null; | ||
| @memmove(array[0 .. array.len - 1], array[1..]); | ||
| return result; |
Contributor
There was a problem hiding this comment.
Should this be clearing the last element after shifting? (i.e., after moving the items then array[array.len - 1] = .none;). Otherwise you're duplicating the last element and if full it'll cause issues?
Btw this PR is an awesome change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes recursion from a various requests:
They may still call into code analysis which uses recursion heavily.
Some other utilities have also been converted:
nodesOverlappingIndex