-
Notifications
You must be signed in to change notification settings - Fork 60
Also use separate UART thread for EZSP TCP coordinators #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #628 +/- ##
==========================================
- Coverage 97.02% 97.02% -0.01%
==========================================
Files 63 63
Lines 10573 10571 -2
==========================================
- Hits 10258 10256 -2
Misses 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Was the underlying issue a pyserial one?
|
2026.1.0 had a regression where voice activity detection spiked CPU usage and caused so much Core stall that we started seeing TCP coordinators being hit with the EZSP timeout reset issue. I was never able to track down the original issue that caused us to introduce this hack but I think we've reorganized connection logic enough to remove this hack and give the bellows thread a try again 😄 |
|
@copilot remove the |
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
|
@copilot Make sure |
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Plan to disable CONF_USE_THREAD override for socket://
Summary
Successfully removed the automatic override of
CONF_USE_THREADtoFalseforsocket://connections. The workaround is no longer needed as the underlying bellows issue has been resolved. Socket connections now use the default thread behavior unless explicitly configured otherwise.The test that verified this behavior has been removed as it's no longer relevant. All pre-commit checks now pass.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.