std.builtin.Type.Pointer.Attributes: "of" helper function#26051
Closed
dotcarmen wants to merge 1 commit intoziglang:masterfrom
Closed
std.builtin.Type.Pointer.Attributes: "of" helper function#26051dotcarmen wants to merge 1 commit intoziglang:masterfrom
dotcarmen wants to merge 1 commit intoziglang:masterfrom
Conversation
Contributor
Author
|
a sensible alternative would be to make this attribute type a field of |
Member
|
I considered this while working on the std migration for #23733, but I think we should hold off for now, because I suspect we'll want to change |
Member
|
This pull request is not ready for review because:
Since we have moved development to Codeberg, please open your pull request there if you would like to continue these efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23733 introduced a new type
std.builtin.Type.Pointer.Attributesfor usage with the new@Pointerbuiltin. however, there's not yet a convenient way to retrieve the information in this struct from astd.builtin.Type.Pointer.this PR introduces a new
offunction to retrieve the pointer attributes from astd.builtin.Type.Pointer. this makes dynamic construction of pointer types simpler and mirrors usage ofstd.Alignment.of