Conversation
|
Fixes #1274 |
@zhanghai If it is required for this pr to be merged, you can have the copyright. |
adambog-comiks
left a comment
There was a problem hiding this comment.
app/src/main/AndroidManifest.xml
| <uses-sdk tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared,rikka.shizuku.provider" /> | ||
|
|
||
| <!-- | ||
| ~ Samsung DeX requires explicitly setting android:resizeableActivity="true" for the app to be |
There was a problem hiding this comment.
Tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared
|
@zhanghai will this get merged? |
Would be a nice Christmas gift indeed |
91a40b0 to
fc12500
Compare
|
Maybe implement some kind of plugin system for this app and then you could use shizuku as a plugin without changing this project license and maybe add different plugins for other things. |
Material Files already supports Sui. Sui and Shizuku use the same api. Adding a plugin system just for this, doesn't make much sense. It's just changing metadata so Shizuku will be used too if available and adjusting a small check (checking if the api is available). Overall very minor code change. So minor I don't think I can even protect it by copyright. But to make it official: I hereby license the changes of this pull request under CC0 (making it available to the public domain). CC: @zhanghai |
Not a large change, but both Sui and Shizuku use the Shizuku-Api.
Currently Material Files only supports Sui.
Shizuku seems to be more maintained than sui. Shizuku supports root as well as rootless (Sui only with root).
This pr adds a small change, that allows Shizuku to be used as well.