Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adapting the application for Play Store submission by addressing key requirements related to user privacy and accessibility service usage. It introduces a clear disclosure for the AccessibilityService API, adds a privacy policy link, and includes a throttling mechanism for accessibility events to improve performance and stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adapts the application for the Google Play Store by adding a prominent disclosure for the Accessibility Service usage and a link to the privacy policy. It also introduces a throttling mechanism for CONTENT_CHANGED events to improve performance. My review includes a critical fix for gradle.properties where a newline is missing, a suggestion to extract hardcoded strings to resources for better maintainability and internationalization, and a recommendation to replace a magic number with a constant.
gradle.properties
Outdated
| KEYSTORE_PASSWORD=touchhelper | ||
| KEY_ALIAS=touchhelper | ||
| KEY_PASSWORD=touchhelper No newline at end of file | ||
| KEY_PASSWORD=touchhelperandroid.suppressUnsupportedCompileSdk=35 |
There was a problem hiding this comment.
It seems like a new property android.suppressUnsupportedCompileSdk=35 was appended to the KEY_PASSWORD line without a newline. This is incorrect and will likely cause build failures or unexpected behavior. Please add a newline before android.suppressUnsupportedCompileSdk=35.
KEY_PASSWORD=touchhelper
android.suppressUnsupportedCompileSdk=35
| } | ||
|
|
||
| long currentTime = System.currentTimeMillis(); | ||
| if (currentTime - lastContentChangedTime < 150) { |
There was a problem hiding this comment.
The value 150 is a magic number. It's better to define it as a named constant to improve readability and maintainability, for example: private static final int CONTENT_CHANGED_THROTTLE_INTERVAL_MS = 150; at the class level.
| new androidx.appcompat.app.AlertDialog.Builder(getContext()) | ||
| .setTitle("重要说明 (Prominent Disclosure)") | ||
| .setMessage("本应用需要使用无障碍服务（AccessibilityService API）来帮您在其他应用中自动查找并点击屏幕上的指定控件（例如各类重复性的按钮）。\n\n本应用属于自动化工具，所有的点击操作均基于您的配置和触发策略。\n本应用完全离线运行，不会收集、存储、传输或分享您的任何个人数据及敏感信息。\n\n请点击“同意”以继续前往系统设置中授权此服务。") | ||
| .setPositiveButton("同意", (dialog, which) -> { | ||
| Intent intent_abs = new Intent(Settings.ACTION_ACCESSIBILITY_SETTINGS); | ||
| intent_abs.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | ||
| startActivity(intent_abs); | ||
| }) | ||
| .setNegativeButton("拒绝", null) | ||
| .show(); |
There was a problem hiding this comment.
The title, message, and button texts for this AlertDialog are hardcoded. It's a best practice to extract these strings into strings.xml resources. This improves maintainability and makes it easier to support multiple languages in the future.
1 participant
No description provided.