Skip to content

Conversation

@Femax
Copy link

@Femax Femax commented Jun 24, 2019

Hi @zesik. I make resize secondary pane after changing secondaryMinSize param.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 99.206% when pulling 2628f04 on Femax:master into e0e5419 on zesik:master.

@zesik
Copy link
Owner

zesik commented Jul 3, 2019

Hi @Femax,

Thanks for catching this and contributing! I have a few questions regarding this:

  1. Changing size in the render function does not reflect on internal state, nor does it trigger resize event. Could you put it somewhere so that we could keep state organized?
  2. Could you add test code for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants