Skip to content

Conversation

@cacharle
Copy link
Contributor

@cacharle cacharle commented Dec 9, 2025

Fixes #670

@cacharle cacharle marked this pull request as draft December 9, 2025 17:50
@cacharle cacharle marked this pull request as ready for review December 9, 2025 18:17
@cacharle
Copy link
Contributor Author

cacharle commented Dec 9, 2025

Not sure why the CI is failing

@gummif
Copy link
Member

gummif commented Dec 10, 2025

Could you try bumping the C++ version of the gcc-9 test to gcc-11?

@cacharle
Copy link
Contributor Author

I think I addressed all of your comments, the CI is still failing tho 🤔

@cacharle cacharle requested a review from gummif December 14, 2025 08:48
@gummif
Copy link
Member

gummif commented Dec 15, 2025

Ok looks good. Just need to figure out this CI issue.

@cacharle
Copy link
Contributor Author

Other PRs have failing CI aswell, probably some dependency wasn't fixed

@cacharle
Copy link
Contributor Author

Need to build libzmq with ENABLE_CURVE (in matrix?), fix the lcov error, add libsodium and clean the git history from all the CI commits

@cacharle
Copy link
Contributor Author

Only failure left is the coverage where it seems there is different versions for my test file:

Processing unit_tests.dir/curve.cpp.gcda
/home/runner/work/cppzmq/cppzmq/build/tests/CMakeFiles/unit_tests.dir/curve.cpp.gcno:version 'B23*', prefer 'B14*'
geninfo: ERROR: GCOV failed for /home/runner/work/cppzmq/cppzmq/build/tests/CMakeFiles/unit_tests.dir/curve.cpp.gcda!

@cacharle
Copy link
Contributor Author

Okay, let me know if you're happy with the end state of the CI (I changed to gcc11, removed some warnings when building libzmq and added a job for the curve feature)
I'll squash all the commits after

@cacharle cacharle force-pushed the add-curve-functions branch from c91d676 to 5b1cf57 Compare December 18, 2025 11:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20334274751

Details

  • 13 of 18 (72.22%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 88.057%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zmq.hpp 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 1 85.71%
zmq_addon.hpp 5 94.18%
Totals Coverage Status
Change from base Build 17909983277: -0.3%
Covered Lines: 929
Relevant Lines: 1055

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20335143482

Details

  • 13 of 18 (72.22%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 88.057%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zmq.hpp 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 1 85.71%
zmq_addon.hpp 5 94.18%
Totals Coverage Status
Change from base Build 17909983277: -0.3%
Covered Lines: 929
Relevant Lines: 1055

💛 - Coveralls

Copy link
Member

@gummif gummif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@gummif gummif merged commit fbbff88 into zeromq:master Dec 19, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add curve functions wrappers

3 participants