Skip to content

fix: use judge parameter in repeatedly log#465

Open
GHX5T-SOL wants to merge 1 commit into
zerocracy:masterfrom
GHX5T-SOL:fix/464-repeatedly-judge-log
Open

fix: use judge parameter in repeatedly log#465
GHX5T-SOL wants to merge 1 commit into
zerocracy:masterfrom
GHX5T-SOL:fix/464-repeatedly-judge-log

Conversation

@GHX5T-SOL
Copy link
Copy Markdown

Summary

  • use the judge: parameter in the Fbe.repeatedly skip log instead of the $judge global
  • add regression coverage for the parameter/global mismatch

Closes #464.

Validation

  • bundle exec ruby test/fbe/test_repeatedly.rb (2 tests, 6 assertions, 0 failures)
  • bundle exec rake test (274 tests, 774 assertions, 0 failures, 9 skips)
  • bundle exec rake rubocop (65 files inspected, no offenses)
  • bundle exec rake yard (completed, 81.82% documented)
  • bundle exec rake picks (exited 0)
  • git diff --check HEAD~1 HEAD (passed)
  • git show --format= --patch HEAD | gitleaks stdin --no-banner --redact --timeout 30 (no leaks found)

Notes

  • Local validation used Homebrew portable Ruby 4.0.3 because the system Ruby is 2.6.10.
  • The test runs emit Ruby 4/Bundler constant redefinition warnings and existing award.rb future frozen string warnings, but the commands above exited 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repeatedly.rb log uses $judge global instead of the judge parameter

1 participant