Skip to content

Conversation

@MrSubidubi
Copy link

This PR updates the workflows for extensions to the latest version from the Zed repository.

@cla-bot cla-bot bot added the cla-signed label Dec 3, 2025
@MrSubidubi
Copy link
Author

Hey @PKief !

Got some new/more workflows for you here. Started working on these recently with the goal of having some more testing/branch protection soonish, especially for not so well maintained extensions as this one (thank you for helping with this), but I think this extension should (hopefully) benefit from this as well.

I do see that in its current form, this would probably not be sufficient for this extension, as you also track the version within the package.json. Happy to dicuss with you how we could tackle this for this extension (or whether we want to skip adding the workflows to this extension for now).

Danke und Gruß aus Kiel!

Copy link
Collaborator

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MrSubidubi thanks for updating the workflows. So far it looks good to me.

You're right, it currently will not cover the update of the dependency to the material icon theme package. Can we add an additional step in the bump version which simply runs the following commands:

      - name: Install dependencies
        run: npm install

      - name: Install latest minor version of material-icon-theme@5.x
        run: npm install material-icon-theme@5.x

      - name: Build project
        run: npm run build

This would basically keep this project in sync with the upstream icon set. And staying at the minor version 5 ensures that there are no breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants