Support DAP debugging via ElixirLS#124
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @andersfischernielsen on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
1 similar comment
|
We require contributors to sign our Contributor License Agreement, and we don't have @andersfischernielsen on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@AlternateRT @maxdeviant, let me know what you think 😄 I'm a bit unsure what the contributing guidelines are for this repo. |
AlternateRT
left a comment
There was a problem hiding this comment.
Hey! Thanks for taking a stab at this issue and sorry for the slow response.
I've left some comments on things to change, but other than that, this looks like a very good start!
Co-authored-by: AltCode <AlternateRT@users.noreply.github.com>
Co-authored-by: AltCode <AlternateRT@users.noreply.github.com>
- Remove name key and use the default location instead - Make `requireFiles` example the default instead - Reorganize fields
This is to future-proof for the potential addition of more debug adapters (e.g. an official one)
AlternateRT
left a comment
There was a problem hiding this comment.
Nice! I pushed some additional changes, mostly to restructure the code.
But other than that we're good to go. Thanks so much for this great contribution!
|
Nice! Thanks for the quick feedback 😄 |
This will add the initial wiring for the DAP of ElixirLS in order to allow debugging Elixir projects.
Fixes #15.
Verified locally by installing the changes as a dev extension: