add release trigger that takes a tag as input#3821
add release trigger that takes a tag as input#3821d-v-b merged 1 commit intozarr-developers:mainfrom
Conversation
This change to `release.yml` should allow us to use `workflow-dispatch`, i.e., manual triggering, to invoke the release workflow, with an explicit tag as input. This supports publishing a tagged release outside of the commit that creates that tag. This is useful for situations where we issued a release, but the github actions workflow was broken in some way that prevented us from uploading the release to pypi.
| - name: Publish package to Test PyPI | ||
| uses: pypa/gh-action-pypi-publish@v1.13.0 | ||
| if: ${{ github.event_name == 'workflow_dispatch' && inputs.test_pypi }} | ||
| with: | ||
| repository-url: https://test.pypi.org/legacy/ |
There was a problem hiding this comment.
I don't think this will work without a token added or OIDC setup. Auth for test PyPI is distinct from PyPI
|
I think this is a clever solution to #3755 (comment), but would rather not have this generally available. For example, I wouldn't want anyone to be able to easily re-publish the prior releases that we've yanked from PyPI. Would you consider just adding an option to deploy 3.1.6 via a workflow dispatch, which we will remove after? The test PyPI additions are helpful. |
I assumed you can't unyank a release, but either way I'm totally fine reverting these changes after we use them to publish 3.1.6. That's the only real reason for doing this PR, once it has fulfilled its purpose the changeset here can be reverted. |
2 participants
This change to
release.ymlshould allow us to useworkflow-dispatch, i.e., manual triggering,to invoke the release workflow, with an explicit tag as input. This supports publishing a tagged
release outside of the commit that creates that tag. This is useful for situations where we issued a
release, but the github actions workflow was broken in some way that prevented us from uploading the
release to pypi.
We can also try pushing to test pypi via the same
workflow-dispatchmechanism.