Conversation
|
cc @emmaualemalthot |
| raise ValueError(f"Unknown rounding mode: {mode}") | ||
|
|
||
|
|
||
| def _cast_array( |
There was a problem hiding this comment.
this implementation is inefficient and will probably remain so as long as we are using python for this.
…ray chunk grids file
…at/v3-scale-offset-cast
…at/v3-scale-offset-cast
|
I'm a bit worried that this implementation is a bit too much stuff for zarr-python, and that perhaps this belongs in a separate project that manages the zarr-python compatibility. Thoughts? |
|
@d-v-b For me it really depends on how we can easily release this PR. How easy is it to release it here and then move to an external package or vice-versa? |
I don't see a lot of value in bundling it in zarr-python, since it seems unlikely that we'd long-term encourage a pure python implementation. I'd recommend a new repository in zarr-developers for easy findability. |
this PR will not be easy to merge, so I'm going to close it and move this functionality to a separate package at https://github.com/zarr-developers/cast-value.py/ |
This PR adds
scale_offsetandcast_valuecodecs. Used together, these codecs replace thefixedscaleoffsetcodec defined in numcodecs.closes #3772
as an experiment, I'm including some developer notes I had claude write in the commit history. We can remove them before merging if we don't want that kind of thing sticking around.