Do not set aws-load-balancer-connection-idle-timeout by default#3054
Draft
Do not set aws-load-balancer-connection-idle-timeout by default#3054
Conversation
hughcapet
requested review from
FxKu,
Jan-M,
idanovinda,
jopadi,
mikkeloscar and
sdudoladov
as code owners
hughcapet
force-pushed
the
no-default-svc-idle-timeout
branch
from
b7f625c to
e6b91b7
Compare
hughcapet
force-pushed
the
no-default-svc-idle-timeout
branch
from
e6b91b7 to
9cc6605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this annotation has no effect on NLBs, remove the default annotation setting. Users can still define it (or the NLB alternative) via custom_service_annotations