fix(hdc): convert duration_ms to swipeVelocityPps_ for HarmonyOS swipe #326
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarmonyOS uitest uses swipeVelocityPps_ instead of duration_ms for swipe command. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modifies the HarmonyOS swipe function to convert the duration parameter to velocity (pixels per second) instead of passing duration directly to the HarmonyOS uitest swipe command. This change aligns with HarmonyOS's uitest API requirements that use velocity-based swipe parameters.
Changes:
- Calculate swipe distance using Euclidean formula and convert duration_ms to swipeVelocityPps_ (velocity in pixels per second)
- Pass velocity parameter to HarmonyOS uitest swipe command instead of duration
- Add velocity clamping (500-40000 pps) to ensure reasonable swipe speeds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HarmonyOS uitest uses swipeVelocityPps_ instead of duration_ms for swipe command.