Skip to content

Conversation

@alcueca
Copy link
Contributor

@alcueca alcueca commented Feb 23, 2023

package.json is a more obvious place to look for than .github/workflows/pull-request.yml if you want to know how to run the tests.

@alcueca alcueca requested a review from Sabnock01 February 23, 2023 15:35
@alcueca
Copy link
Contributor Author

alcueca commented Feb 23, 2023

There is a failing test, which I don't think is related to this PR:

2023-02-23T15:37:08.3105748Z Failing tests:
2023-02-23T15:37:08.3105923Z Encountered 1 failing test in src/test/YieldMath.t.sol:YieldMathTest
2023-02-23T15:37:08.3106561Z �[31m[FAIL. Reason: YieldMath: > fyToken reserves Counterexample: calldata=0x13172fa400000000000000000000000000000000000000000000e8ef1e96ae3897800000, args=[1100000000000000000000000]]�[0m testFuzz_fyTokenInForSharesOut_farFromMaturity(uint128) (runs: 495, μ: 38468, ~: 38577)

@Sabnock01
Copy link
Contributor

There is a failing test, which I don't think is related to this PR:

2023-02-23T15:37:08.3105748Z Failing tests:
2023-02-23T15:37:08.3105923Z Encountered 1 failing test in src/test/YieldMath.t.sol:YieldMathTest
2023-02-23T15:37:08.3106561Z �[31m[FAIL. Reason: YieldMath: > fyToken reserves Counterexample: calldata=0x13172fa400000000000000000000000000000000000000000000e8ef1e96ae3897800000, args=[1100000000000000000000000]]�[0m testFuzz_fyTokenInForSharesOut_farFromMaturity(uint128) (runs: 495, μ: 38468, ~: 38577)

I've seen that one come up from time to time but not sure about it myself. Certainly not related to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants