Nikita frontend refactor#103
Open
niksaitov wants to merge 11 commits into
Open
Conversation
…ated with posting a ride
… is always set to false
…encapsulate prisma call from main page in library function
…rom interface file
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the feed, your-rides, and bookmarks pages for style guide compliance and cleaner component boundaries. The feed page's search logic is extracted into a dedicated hook,
ShareYideDialognow owns all post-ride state, andTopBaris simplified. The your-rides page drops the redundant bookmarked-IDs fetch and encapsulates its Prisma call behind a library function. Unused components, stale comments, and orphaned props are removed throughout.Changes
Main Contributors
Nikita Saitov
Checklist
nikita-backend-refactorbranch (will be rebased tomainafter backend PR merges)Notes for Reviewers
IMPORTANT: This PR depends on
nikita-backend-refactorand should be reviewed after that one!Key areas to focus on: the new
useRideSearchhook in the feed page, and the state ownership change inShareYideDialog. The your-rides page no longer fetches bookmarked IDs since they were never used (bookmark was initialized to false).