feat: add actix support for yew-link by stifskere · Pull Request #4113 · yewstack/yew

stifskere · 2026-04-04T18:35:54Z

Description

Adds actix_web support for the yew_link crate introduced in #4027.

Checklist

I have reviewed my own code
I have added tests

stifskere · 2026-04-04T18:57:21Z

The workflow error is a network request error.

I assume the workflow could be re-run as I don't see any reason why would that specific workflow fail.

Madoshakalaka · 2026-04-04T19:01:08Z

I restarted the workflow

Madoshakalaka

I merged master into the yew-link branch. Can you merge from yew-link first and then address the reviews?

website/docs/advanced-topics/server-side-rendering.mdx

.gitignore

packages/yew-link/src/services.rs

Cargo.toml

packages/yew-link/src/services.rs

website/docs/advanced-topics/server-side-rendering.mdx

stifskere · 2026-04-04T21:13:13Z

I merged master into the yew-link branch. Can you merge from yew-link first and then address the reviews?

It's quite late in here, I will address it tomorrow when I have the chance.

website/docs/advanced-topics/server-side-rendering.mdx

… separators

stifskere · 2026-04-04T22:30:39Z

I didn't realize you meant the ,, I thought you meant the use statements xD.

Madoshakalaka

Can you also come up with an SSR actix-web example in examples and extend tools/ssr-e2e to test it? Possibly will also involve tweaking the end of .github/workflows/main-checks.yml. Also don't forget to include it in the table in examples/README.md

It's quite important because

I don't personally use actix-web so I have less confidence this works perfectly.
It will be our first actix example (we had warp and axum examples only)
this will lend us more confidence in future refactoring.

website/docs/advanced-topics/server-side-rendering.mdx

…documentation

website/docs/advanced-topics/server-side-rendering.mdx

… of actix or axum

stifskere · 2026-04-06T18:00:12Z

About tweaking ssr-e2e, I don't think it's needed because the whole point of actix_web is making things simpler, there is no external needs or dependencies, if it worked with Axum, it can work with actix_web meanwhile it has the same configuration.

stifskere · 2026-04-06T18:37:09Z

Ok, so on my side I have resolved the merge conflict, now the yewstack/yew:yew-link branch must be updated.

…to-stifskere # Conflicts: # Cargo.lock # examples/actix_ssr_router/src/lib.rs # examples/axum_ssr_router/src/bin/ssr_router_server.rs # packages/yew-link/src/lib.rs

…sr_router

Madoshakalaka · 2026-04-07T08:34:32Z

Thanks.

I took the liberty of merging some un-resolved changes.

Changes look good with a few more details like i18n to iron out. I'll ask my clanker to synchronize doc changes to the i18n pages. Can you leave it to me?

stifskere · 2026-04-07T08:54:37Z

Thanks.

I took the liberty of merging some un-resolved changes.

Changes look good with a few more details like i18n to iron out. I'll ask my clanker to synchronize doc changes to the i18n pages. Can you leave it to me?

For sure, ping me on discord or here if you need anything.

Madoshakalaka · 2026-04-07T08:55:26Z

good

The linked_state_handler in yew-link extracts Data<Resolver>, but the server only registered Data<AppState>, returning 500. Install the inner Arc<Resolver> as Data<Resolver> via app_data alongside the AppState. Also set content_type=text/html on the SSR streaming response so browsers render it instead of downloading it.

Madoshakalaka

I think this PR is complete now.

An extra refactoring opportunity is to extract common code between axum_ssr_router and actix_ssr_router.

I'm against it because examples are meant to show users straightforwardly how our code works. We should not require them to navigate between multiple abstractions irrelevant to their final project structure.

So this will stay as some intentional duplication.

Note we already made the two examples rely on a central ssr_router client-side-only example. This is a prior decision and I'm not sure if we should go out of our way to undo it.

feat: add actix support for yew-link

2e2dd08

Madoshakalaka requested changes Apr 4, 2026

View reviewed changes

stifskere added 2 commits April 4, 2026 23:53

Merge branch 'yewstack:yew-link' into yew-link

fefd7a7

fix: yewstack#4113 errors from first commit

11bee31

Madoshakalaka requested changes Apr 4, 2026

View reviewed changes

website/docs/advanced-topics/server-side-rendering.mdx Show resolved Hide resolved

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

stifskere requested a review from Madoshakalaka April 4, 2026 22:19

Madoshakalaka requested changes Apr 4, 2026

View reviewed changes

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

fix: yewstack#4113 server-side-rendering documentation codeblock type…

032699b

… separators

Madoshakalaka requested changes Apr 4, 2026

View reviewed changes

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

Madoshakalaka added the A-yew-link Area: The yew-link crate label Apr 4, 2026

docs: yewstack#4113 add an example of actix yew_link resolver in the …

2623a6c

…documentation

Madoshakalaka requested changes Apr 5, 2026

View reviewed changes

website/docs/advanced-topics/server-side-rendering.mdx Outdated Show resolved Hide resolved

stifskere added 3 commits April 6, 2026 17:21

chore: yewstack#4113 put services module under feature enabled by any…

11d8ffb

… of actix or axum

chore: yewstack#4113 add a test for actix_ssr_router using yew_link

e0ce4f2

docs: yewstack#4113 add the example changes to examples/readme.md

686fc3d

chore: yewstack#4113 resolve merge conflict from master to yew-router

90a626b

Madoshakalaka added 3 commits April 7, 2026 17:24

Merge remote-tracking branch 'origin/yew-link' into merge-yew-link-in…

0b9b59f

…to-stifskere # Conflicts: # Cargo.lock # examples/actix_ssr_router/src/lib.rs # examples/axum_ssr_router/src/bin/ssr_router_server.rs # packages/yew-link/src/lib.rs

fix: bump actix_ssr_router to edition 2024 and fmt

bccf5d0

ci: update SSR E2E matrix for renamed axum_ssr_router and new actix_s…

26323c5

…sr_router

fix: update e2e tests to import from renamed crates

423a77e

fix: actix_ssr_router needs CORS and static file serving for e2e

5990ef8

Madoshakalaka added 2 commits April 7, 2026 19:02

fix: feature soundness, CI, website i18n

30ec78e

Madoshakalaka force-pushed the yew-link branch from 5e3299d to 6759dc5 Compare April 7, 2026 12:59

test(website): test native snippets too

81b3e6e

Madoshakalaka force-pushed the yew-link branch from 1d43081 to 81b3e6e Compare April 7, 2026 14:03

Madoshakalaka added 2 commits April 8, 2026 00:09

fix(yew-link): test snippets

93cbfce

refactor: extract common ssr example testing code

082854c

Madoshakalaka approved these changes Apr 7, 2026

View reviewed changes

Madoshakalaka merged commit d4f595e into yewstack:yew-link Apr 7, 2026
32 checks passed

Uh oh!

Conversation

stifskere commented Apr 4, 2026

Description

Checklist

Uh oh!

stifskere commented Apr 4, 2026

Uh oh!

Madoshakalaka commented Apr 4, 2026

Uh oh!

Madoshakalaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stifskere commented Apr 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stifskere commented Apr 4, 2026

Uh oh!

Madoshakalaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stifskere commented Apr 6, 2026

Uh oh!

stifskere commented Apr 6, 2026

Uh oh!

Madoshakalaka commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stifskere commented Apr 7, 2026

Uh oh!

Madoshakalaka commented Apr 7, 2026

Uh oh!

Madoshakalaka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Madoshakalaka commented Apr 7, 2026 •

edited

Loading

Madoshakalaka left a comment •

edited

Loading