wip: add a screenshot test for svg rendering#3895
Draft
Madoshakalaka wants to merge 1 commit intomasterfrom
Draft
wip: add a screenshot test for svg rendering#3895Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Screenshot code is adapted from https://github.com/xataio/screenshot/ |
Madoshakalaka
commented
Aug 10, 2025
Comment on lines
+1
to
+8
| { | ||
| "goog:chromeOptions": { | ||
| "args": [ | ||
| "--use-fake-ui-for-media-stream", | ||
| "--use-fake-device-for-media-stream" | ||
| ] | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
other options can be found here: https://peter.sh/experiments/chromium-command-line-switches/
|
Visit the preview URL for this PR (updated for commit b6de2dd): https://yew-rs-api--pr3895-screenshot-a3qpjxg5.web.app (expires Sun, 17 Aug 2025 14:56:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
3f36350 to
b6de2dd
Compare
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current master branch renders a white screen (at least on Chrome) because it converts svg element names to lower case:
here is a minimal repo https://github.com/Madoshakalaka/svg-dropshadow
Trying to add a test with screenshot to confirm this.
But I keep getting a green pacman
to reproduce
chromedriverit will print a base64 pacman image somehow