yew/vlist: optimize diffing and patching#1555
Conversation
|
yew-functional CI tests seem to have failed due to chromedriver. |
|
@bakape perf looks good for
|
|
Also, I fixed the macro tests on master fyi |
|
The regression was introduced in e6c965b, which is very odd. I don't see anything there that could have caused it. I'll rebase and merge master anew. |
e0c888f to
a40faf4
Compare
666e6ce to
1639635
Compare
1639635 to
368e5ea
Compare
|
@jstarry Sorry, I've been busy with other matters and projects for a while. I've fixed the swap issue and added a few other optimizations. |
|
No worries, I've been busy as well. Will review soon |
|
I'm looking forward to see this merged \o/ |
|
It's been forgotten, it seems. A lot to review, so understandable finding time might be hard. |
teymour-aldridge
left a comment
There was a problem hiding this comment.
Just some thoughts
| ) -> NodeRef { | ||
| use std::mem::{transmute, MaybeUninit}; | ||
|
|
||
| macro_rules! map_keys { |
There was a problem hiding this comment.
I'm not sure about the benefit of using a macro here (especially with an eye towards compile times).
There was a problem hiding this comment.
It saves us from copy-pasting and I think the compile costs are negligible. Especially so, with how much the html! procedural macro does.
Co-authored-by: Teymour Aldridge <notifications@reasoning.page> Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
ranile
left a comment
There was a problem hiding this comment.
Apart from this comment, this looks good to me.
| "VText {{ text: \"{}\", reference: {} }}", | ||
| self.text, | ||
| match &self.reference { | ||
| Some(_) => "Some(...)", |
There was a problem hiding this comment.
Nit: maybe also print the VText's content? Or is that not possible?
There was a problem hiding this comment.
This was intentional, as it made the debug log output much more unreadable. Especially so in already verbose log output, like the one I added to the layout tests.
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>


Description
Debugoutput of some typesChecklist:
./ci/run_stable_checks.sh