Skip to content

Conversation

@jkeuhlen
Copy link
Contributor

@jkeuhlen jkeuhlen commented Sep 4, 2025

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran fourmolu on any changed files (restyled will do this for you, so
    accept the suggested changes if it makes them)
  • Adhered to the code style (see the .editorconfig and fourmolu.yaml files for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This implements 2/3/4 from #1607

@jkeuhlen jkeuhlen marked this pull request as draft September 4, 2025 22:14
Resolved conflicts:
- persistent-postgresql.cabal: kept both MigrationSpec and NullsNotDistinctTest modules
- TH/Internal.hs: merged error message to include both nullsNotDistinct option and getBy warning
- Internal.hs: took master's refactored version (migration code moved to Internal/Migration.hs)
- Applied NullsNotDistinct changes to the new Internal/Migration.hs location:
  - Added [Attr] parameter to AddUniqueConstraint
  - Updated udToPair to return triple including uniqueAttrs
  - Added NULLS NOT DISTINCT clause in showAlterTable
  - Updated getAlters and related functions for new tuple types

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant