Knn python tests #30328
Knn python tests #30328
Conversation
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR adds Python tests for KNN (K-Nearest Neighbors) functionality in YDB, enabling testing of brute-force KNN searches without vector indexes alongside existing vector index tests.
Key Changes:
- New comprehensive KNN test suite covering multiple distance and similarity functions
- Integration of KNN brute-force search testing into stress workload and compatibility tests
- Support for testing KNN operations during rolling upgrades/downgrades
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ydb/tests/datashard/ya.make |
Added knn subdirectory to the build recursion list |
ydb/tests/datashard/knn/ya.make |
Build configuration for new KNN test suite with appropriate test size settings |
ydb/tests/datashard/knn/test_knn.py |
New test suite with 7 test methods covering CosineDistance, CosineSimilarity, InnerProductSimilarity, ManhattanDistance, EuclideanDistance, result verification, two-stage queries, and subquery targets |
ydb/tests/stress/oltp_workload/workload/type/vector_index.py |
Added _knn_search and _knn_search_check methods for brute-force KNN testing without vector indexes, integrated into the existing workload check loop |
ydb/tests/compatibility/test_vector_index.py |
Added _get_knn_queries and knn_search methods to test KNN functionality during rolling upgrade/downgrade scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
BackportTo backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.
|
3 participants
Changelog entry
Changelog category
Description for reviewers
...