Skip to content

Fix attach stream finish logic #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvoleg merged 1 commit into from
Jan 26, 2026
Merged

Fix attach stream finish logic #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ydb/aio/query/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ async def _check_session_status_loop(self) -> None:
logger.debug("Attach stream closed, session_id: %s", self._session_id)
except Exception as e:
logger.debug("Attach stream error: %s, session_id: %s", e, self._session_id)
finally:
self._invalidate()

async def delete(self, settings: Optional[BaseRequestSettings] = None) -> None:
Expand Down
2 changes: 0 additions & 2 deletions ydb/query/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def _check_session_ready_to_use(self) -> None:
def _invalidate(self) -> None:
if self._closed:
return

self._closed = True

if self._stream is not None:
Expand Down Expand Up @@ -228,7 +227,6 @@ def _check_session_status_loop(self, status_stream: _utilities.SyncResponseItera
logger.debug("Attach stream closed, session_id: %s", self._session_id)
except Exception as e:
logger.debug("Attach stream error: %s, session_id: %s", e, self._session_id)
finally:
self._invalidate()

def delete(self, settings: Optional[BaseRequestSettings] = None) -> None:
Expand Down
Loading