Fixed wrong type in ApacheArrowPartsHandler#608
Merged
alex268 merged 1 commit intoydb-platform:masterfrom Mar 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
============================================
+ Coverage 68.85% 68.87% +0.01%
- Complexity 3128 3130 +2
============================================
Files 355 355
Lines 15304 15304
Branches 1621 1621
============================================
+ Hits 10538 10541 +3
+ Misses 4101 4100 -1
+ Partials 665 663 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnv1
previously approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Apache Arrow query-result handling to accept the correct allocator abstraction and adjusts/extends integration tests around Apache Arrow bulk upserts and query reading.
Changes:
- Update
ApacheArrowPartsHandler/ApacheArrowCompressedPartsHandlerconstructors to acceptBufferAllocatorinstead ofRootAllocator. - Add an ignored integration test intended to reproduce an Apache Arrow text edge case, and refactor table creation in Arrow bulk upsert tests to use a shared helper.
- Refactor
ApacheArrowTesttable initialization to reuse constants (but also changes the intended store type for the “column” table).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| table/src/test/java/tech/ydb/table/integration/BulkUpsertTest.java | Adds an ignored Arrow test case + uses createTable(...) helper in Arrow tests |
| query/src/test/java/tech/ydb/query/impl/ApacheArrowTest.java | Refactors table init to use constants; changes “column” table description |
| query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowPartsHandler.java | Changes allocator type to BufferAllocator in public API constructor |
| query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowCompressedPartsHandler.java | Propagates allocator type change to compressed handler constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
table/src/test/java/tech/ydb/table/integration/BulkUpsertTest.java
Outdated
Show resolved
Hide resolved
table/src/test/java/tech/ydb/table/integration/BulkUpsertTest.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowPartsHandler.java
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowCompressedPartsHandler.java
Show resolved
Hide resolved
pnv1
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.