Skip to content

Fixed wrong type in ApacheArrowPartsHandler#608

Merged
alex268 merged 1 commit intoydb-platform:masterfrom
alex268:master
Mar 23, 2026
Merged

Fixed wrong type in ApacheArrowPartsHandler#608
alex268 merged 1 commit intoydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Mar 20, 2026

No description provided.

@alex268 alex268 requested a review from pnv1 March 20, 2026 16:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.87%. Comparing base (28d9fed) to head (103e3e3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
+ Coverage     68.85%   68.87%   +0.01%     
- Complexity     3128     3130       +2     
============================================
  Files           355      355              
  Lines         15304    15304              
  Branches       1621     1621              
============================================
+ Hits          10538    10541       +3     
+ Misses         4101     4100       -1     
+ Partials        665      663       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pnv1 pnv1 requested a review from Copilot March 20, 2026 17:06
pnv1
pnv1 previously approved these changes Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Apache Arrow query-result handling to accept the correct allocator abstraction and adjusts/extends integration tests around Apache Arrow bulk upserts and query reading.

Changes:

  • Update ApacheArrowPartsHandler / ApacheArrowCompressedPartsHandler constructors to accept BufferAllocator instead of RootAllocator.
  • Add an ignored integration test intended to reproduce an Apache Arrow text edge case, and refactor table creation in Arrow bulk upsert tests to use a shared helper.
  • Refactor ApacheArrowTest table initialization to reuse constants (but also changes the intended store type for the “column” table).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
table/src/test/java/tech/ydb/table/integration/BulkUpsertTest.java Adds an ignored Arrow test case + uses createTable(...) helper in Arrow tests
query/src/test/java/tech/ydb/query/impl/ApacheArrowTest.java Refactors table init to use constants; changes “column” table description
query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowPartsHandler.java Changes allocator type to BufferAllocator in public API constructor
query/src/main/java/tech/ydb/query/result/arrow/ApacheArrowCompressedPartsHandler.java Propagates allocator type change to compressed handler constructor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex268 alex268 merged commit cd96025 into ydb-platform:master Mar 23, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants