533. Fix race condition between onStartPartitionSession and onPartitionSessionClosed#605
Open
ekuvardin wants to merge 10 commits intoydb-platform:masterfrom
Hidden character warning
The head ref may contain hidden characters: "533.\u0421ontrol-event-ordering"
Open
533. Fix race condition between onStartPartitionSession and onPartitionSessionClosed#605ekuvardin wants to merge 10 commits intoydb-platform:masterfrom
ekuvardin wants to merge 10 commits intoydb-platform:masterfrom
Conversation
ekuvardin
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
============================================
+ Coverage 68.85% 69.05% +0.19%
- Complexity 3128 3138 +10
============================================
Files 355 355
Lines 15304 15306 +2
Branches 1621 1621
============================================
+ Hits 10538 10569 +31
+ Misses 4101 4069 -32
- Partials 665 668 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rdering # Conflicts: # topic/src/main/java/tech/ydb/topic/read/impl/AsyncReaderImpl.java # topic/src/main/java/tech/ydb/topic/read/impl/ReaderImpl.java # topic/src/main/java/tech/ydb/topic/read/impl/SyncReaderImpl.java
Contributor
Author
|
Merge last trunk update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #553
AsyncReader.onStartPartitionSession can be called before AsyncReader.onPartitionSessionClosed due to race condition
By the way onStopPartitionSession managed by ydb core and after running some test examples couldn't find any races
I write two test
testEventOrderingGuarantees - guarantees in one reader
testSessionCloseRaceCondition - guarantees in two reader and simulate situation like in attached issues