fix: Disable ordinal select item references#211
Merged
KirillKurdyukov merged 1 commit intoydb-platform:mainfrom Mar 23, 2026
Merged
fix: Disable ordinal select item references#211KirillKurdyukov merged 1 commit intoydb-platform:mainfrom
KirillKurdyukov merged 1 commit intoydb-platform:mainfrom
Conversation
KirillKurdyukov
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ydb does not support ordinal as item reference. For example query like
select * from table order by 1.It is documented in https://ydb.tech/docs/en/yql/reference/syntax/select/order_by?version=v25.2.
So in this PR I made
supportsOrdinalSelectItemReferenceto return false, to such queries worked in hibernate.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
supportsOrdinalSelectItemReferenceby default returns true in abstract dialect classIssue Number: N/A
What is the new behavior?
overriden
supportsOrdinalSelectItemReferencefunction to return false inYdbDialect, so queries withorder by 1andgroup by 1are now working.Other information
https://docs.hibernate.org/orm/7.3/javadocs/org/hibernate/dialect/Dialect.html#supportsOrdinalSelectItemReference()