fix: Do not use Unicode functions on lower and upper functions because of type incompatibility with string#210
Open
inoorinoor wants to merge 1 commit intoydb-platform:mainfrom
Conversation
…e of type incompatibility with string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query like this
select e from StringEntity e where lower(e.name) like lower(concat('%', :search, '%'))fails with type incompatibility with Utf8 and StringThis happens because lower and upper function are implemented by Unicode functions.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Query like this
select e from StringEntity e where lower(e.name) like lower(concat('%', :search, '%'))fails with120:2 - 120:2: Mismatch type argument #1, type diff: Utf8!=String (S_ERROR)]error because in lower and upper functions are usedUnicode::ToLowerandUnicode::ToUpper.Issue Number: N/A
What is the new behavior?
Unicode::ToLowertoString::AsciiToLowerUnicode::ToUppertoString::AsciiToUpperOther information
Added test that produces bug