Skip to content

Conversation

@DaryaVorontsova
Copy link
Contributor

@DaryaVorontsova DaryaVorontsova commented Dec 10, 2025

The partitions progress bar is hidden behind a window flag for now.

To enable it in the browser, run in DevTools console:

window.WINDOW_SHOW_TABLE_SETTINGS = true;
Stand: https://nda.ya.ru/t/0KO6gq_k7PvGjP
In this database you can see different tables with different number of partitions (with min, max, less then min, with no max)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
384 381 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 62.54 MB | Main: 62.52 MB
Diff: +0.02 MB (0.03%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@DaryaVorontsova DaryaVorontsova marked this pull request as draft December 10, 2025 15:30
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@DaryaVorontsova DaryaVorontsova marked this pull request as ready for review December 10, 2025 17:08
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, no comments

Edit Code Review Agent Settings | Greptile


// Feature flag: show partitions progress only if WINDOW_SHOW_TABLE_SETTINGS is truthy
const isPartitionsProgressEnabled = Boolean(
(window as unknown as {WINDOW_SHOW_TABLE_SETTINGS?: unknown}).WINDOW_SHOW_TABLE_SETTINGS,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add type to window.d.ts to avoid "as unknown"

Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of questions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

const width = `${value}%`;

return (
<div
Copy link
Contributor Author

@DaryaVorontsova DaryaVorontsova Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to use Progress component, because when we have only main progress bar and if the value of current partitions is quite small, we should fix min-width in 20 px for filling part (designer said). Progress component doesn't allow to do it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@ydb-platform ydb-platform deleted a comment from cursor bot Dec 17, 2025
partitionProgressConfig,
} = React.useMemo(() => prepareTableInfo(data, type), [data, type]);

// Feature flag: show partitions progress only if WINDOW_SHOW_TABLE_SETTINGS is truthy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it intended to be set to truthy on prod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want that users won't see these changes until all work of this task is finished...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we do things like that via uiFactory

search codebase for

export interface UIFactory<H extends string = CommonIssueType, T extends string = string> {

I think these examples look like what you may use

    hasAccess?: boolean;
    hideGrantAccess?: boolean;

    useDatabaseId?: boolean;

    useMetaProxy?: boolean;
    useClusterDomain?: boolean;

@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 9acc9f4 Dec 17, 2025
9 checks passed
@DaryaVorontsova DaryaVorontsova deleted the feat/new-progress-bar branch December 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new progress bar in the top of the page of table settings

3 participants