Skip to content

Store file hash in config #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybnd wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Store file hash in config #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cebaef
Advance version
ybnd Jan 30, 2021
15ca102
Add FileConfig to hold path and hash of files
ybnd Jan 30, 2021
2a98495
Handle configuration change in normalize_config()
ybnd Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shapeflow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import diskcache


__version__: str = '0.4.3'
__version__: str = '0.4.4'
"""Library version
"""

Expand Down
7 changes: 7 additions & 0 deletions shapeflow/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,13 @@ def normalizing_to(version):
# rename parameters -> feature_parameters
if 'parameters' in d:
d['feature_parameters'] = d.pop('parameters')
if before_version(d[VERSION], '0.4.4'):
normalizing_to('0.4.4')
# move video_path & design_path to video.path & design.path
if 'video_path' in d:
d['video'] = {'path': d.pop('video_path')}
if 'design_path' in d:
d['design'] = {'path': d.pop('design_path')}

else:
raise NotImplementedError
Expand Down
12 changes: 9 additions & 3 deletions shapeflow/core/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import numpy as np
import pandas as pd

from pydantic import Field
from pydantic import Field, FilePath

from shapeflow import settings, get_logger, get_cache
from shapeflow.api import api
Expand Down Expand Up @@ -486,14 +486,20 @@ def __modify_schema__(cls, field_schema):
)


class FileConfig(BaseConfig):
path: Optional[FilePath] = Field(default=None)
hash: Optional[FilePath] = Field(default=None)


class BaseAnalyzerConfig(BaseConfig):
"""Abstract analyzer configuration.
"""
video_path: Optional[str] = Field(default=None)
design_path: Optional[str] = Field(default=None)
name: Optional[str] = Field(default=None)
description: Optional[str] = Field(default=None)

video: FileConfig = Field(default_factory=FileConfig)
design: FileConfig = Field(default_factory=FileConfig)


class BaseAnalyzer(Instance, RootInstance):
"""Abstract analyzer.
Expand Down