Skip to content

Conversation

@malkusch
Copy link

The URI Schemes add-on prefixes some URI schemes with UTF-8 symbols. In this initial version these schemes:
mailto: ✉
tel: ☎
bitcoin: B⃦

@michsch
Copy link
Member

michsch commented Jan 25, 2014

YAML is developed with Sass right now. So all the CSS should be compiled through Sass. Please don't create new CSS files (or change them). Instead you have to create new Sass (.scss) files.

@michsch
Copy link
Member

michsch commented Feb 9, 2014

Thank you for these changes. I just don't know what's the best solution: Use unicode chars in CSS/Sass directly or unicode hex codes?

/* Unicode hex input */
content: "\2709"; /* ✉ */
content: "\260e"; /* ☎ */
content: "\0042"; /* B⃦ */

In my opinion it's worth to merge, @djesse.

@oliverklee
Copy link
Contributor

If the CSS files are expected to be UTF-8, the characters should be okay (without the hex representation).

@djesse
Copy link
Contributor

djesse commented Feb 17, 2014

UTF8 characters can be very tricky when Sass is compiled to CSS on Windows. Therefore, I would prefer the suggestion from @michsch to use unicode hex codes as I do for the custom button icons.

I'm not convinced, that these supplements justify a separate add-on. There are A LOT of URI schemes and this Sass code only provides icon solutions for three schemes and it's not expandable due to the lack of suitable UTF8 characters.

Despite that I think, this is a way of link styling that should be added on project/user level. It's not a feature that necessarily should be provided by the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants