Fix parsing JSON files #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a `allowEmptyContent: true` option in jsonc-parser's `parse` method to allow empty json files without it erroring.
- Added `encoding: "utf"` option to Node's `readFileSync` in the `readJsonFile` util function. This is to ensure files are read as utf8 encoding. - Fixed `Invalid Symbol` parsing error. This could happen if the JSON file is saved as encoding UTF-8 with BOM, it's the BOM marker at the start of the file that fails parsing. So we remove the BOM character codes from the contents before parsing it. ref: https://stackoverflow.com/a/24376813/2358222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various errors brought up in comments in #14.
Changes:
File reading and parsing improvements in
readJsonFileutil functionInvalid Symbolparsing error).Value Expectedparsing error) - the parser needed an extra opt-in option to prevent erroring on empty files.