Skip to content

disable module name parsing #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xtuc merged 1 commit into from
Jul 23, 2018
Merged

disable module name parsing #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions packages/wasm-parser/src/decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,12 +1101,23 @@ export function decode(ab: ArrayBuffer, opts: DecoderOpts): Program {
return t.globalType(type, globalType);
}

function parseNameModule() {
const name = readUTF8String();
eatBytes(name.nextIndex);
// function parseNameModule() {
// const lenu32 = readVaruint32();
// eatBytes(lenu32.nextIndex);

return [t.moduleNameMetadata(name.value)];
}
// console.log("len", lenu32);

// const strlen = lenu32.value;

// dump([strlen], "string length");

// const bytes = readBytes(strlen);
// eatBytes(strlen);

// const value = utf8.decode(bytes);

// return [t.moduleNameMetadata(value)];
// }

// this section contains an array of function names and indices
function parseNameSectionFunctions() {
Expand Down Expand Up @@ -1178,10 +1189,16 @@ export function decode(ab: ArrayBuffer, opts: DecoderOpts): Program {
eatBytes(subSectionSizeInBytesu32.nextIndex);

switch (sectionTypeByte.value) {
case 0: {
nameMetadata.push(...parseNameModule());
break;
}
// case 0: {
// TODO(sven): re-enable that
// Current status: it seems that when we decode the module's name
// no name_payload_len is used.
//
// See https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#name-section
//
// nameMetadata.push(...parseNameModule());
// break;
// }
case 1: {
nameMetadata.push(...parseNameSectionFunctions());
break;
Expand Down