Skip to content

Conversation

@ndw
Copy link
Collaborator

@ndw ndw commented Feb 27, 2025

It seems like a consensus is forming to add a p:message step, so I took a stab at describing it.

The only open question in my mind is, if the test expression is false(), is the implementation forbidden from evaluating the select expression or is that implementation-dependent. (Or implementation-defined, I guess.)

@ndw ndw requested a review from a team as a code owner February 27, 2025 18:05
@ndw
Copy link
Collaborator Author

ndw commented Feb 27, 2025

Fix #672

@xml-project
Copy link
Member

It seems like a consensus is forming to add a p:message step, so I took a stab at describing it.

The only open question in my mind is, if the test expression is false(), is the implementation forbidden from evaluating the select expression or is that implementation-dependent. (Or implementation-defined, I guess.)

I am not sure we need to say something special here. There are other cases in evaluating a pipeline where a processor knows that an option is not used and therefore does not have to be evaluated, e.g. if match in p:add-attribute does not match anything, attribute-name and attribute-value don't have to be evauated.

The difference in user experience is (a) enhanced speed and (b) missing error messages resulting from the non evaluated expressions, right? I would think this could be implementation-dependent.

@ndw ndw merged commit 7b2a9b2 into xproc:master Feb 28, 2025
2 checks passed
@ndw ndw deleted the p-message branch February 28, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants