Closed
Conversation
added 3 commits
January 7, 2026 08:58
- Updated .gitignore for numbered directory structure - Implemented shared UI components library (Aquiis.UI.Shared) - Updated Account pages with proper Blazor lifecycle patterns - Updated PropertyManagement pages with proper lifecycle patterns - All 303 unit tests passing - Clean Architecture fully implemented (Plans 10 & 11)
xnodeoncode
added
🔧 enhancement
There was a problem hiding this comment.
Pull request overview
This PR completes the shared UI implementation, enabling product development to diverge safely with common components centralized in the Shared UI library. The changes introduce comprehensive workflow services for application lifecycle management, enhanced service layer functionality, and PDF generation capabilities.
Changes:
- Implemented workflow state machine infrastructure with audit logging for rental applications and leases
- Added comprehensive service classes for managing tenants, payments, tours, and screenings
- Integrated PDF generation for various documents (invoices, leases, receipts, reports, checklists)
Reviewed changes
Copilot reviewed 110 out of 1593 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IWorkflowState.cs | Defines workflow state machine interface for status transition validation |
| BaseWorkflowService.cs | Provides transaction support and audit logging infrastructure for all workflows |
| ApplicationWorkflowService.cs | Implements rental application lifecycle management with state transitions |
| AccountWorkflowService.cs | Placeholder workflow service for account state management |
| TourService.cs | Manages property tour scheduling and status tracking |
| TenantService.cs | Handles tenant CRUD operations with validation |
| TenantConversionService.cs | Converts prospective tenants to active tenants during lease signing |
| SecurityDepositService.cs | Manages security deposits, investment pools, and dividend distribution |
| ScreeningService.cs | Handles application screening with background/credit checks |
| SchemaValidationService.cs | Validates database schema version compatibility |
| ScheduledTaskService.cs | Background service for automated tasks (late fees, notifications, expirations) |
| SMSSettingsService.cs | Manages SMS provider configuration and settings |
| SMSService.cs | Provides SMS sending functionality |
| RentalApplicationService.cs | Manages rental application entities with business logic |
| ProspectiveTenantService.cs | Handles prospective tenant management |
| PropertyService.cs | Manages property entities with inspection scheduling |
| PaymentPdfGenerator.cs | Generates payment receipt PDFs |
| LeaseRenewalPdfGenerator.cs | Creates lease renewal offer documents |
| LeasePdfGenerator.cs | Generates lease agreement PDFs |
| InvoicePdfGenerator.cs | Produces invoice PDFs with payment details |
| InspectionPdfGenerator.cs | Creates property inspection report PDFs |
| FinancialReportPdfGenerator.cs | Generates financial reports (income statements, rent rolls) |
| ChecklistPdfGenerator.cs | Produces checklist PDFs with custom font support |
| PaymentService.cs | Manages payment processing with automatic invoice updates |
| OrganizationService.cs | Handles organization management and user access control |
| NotificationService.cs | Sends notifications via in-app, email, and SMS channels |
| NoteService.cs | Manages entity notes with soft delete support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Closing PR no longer needed. Changes included in Shared UI Implementation PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared ui implementation is complete. Product development can now diverge safely with common components being in the Shared UI library.