Merged
Conversation
added 4 commits
January 10, 2026 08:42
- Updated .gitignore for numbered directory structure - Implemented shared UI components library (Aquiis.UI.Shared) - Updated Account pages with proper Blazor lifecycle patterns - Updated PropertyManagement pages with proper lifecycle patterns - All 303 unit tests passing - Clean Architecture fully implemented (Plans 10 & 11)
Removed duplicate directories from before the numbered reorganization: - Aquiis.Application/ → now 2-Aquiis.Application/ - Aquiis.Core/ → now 0-Aquiis.Core/ - Aquiis.Infrastructure/ → now 1-Aquiis.Infrastructure/ - Aquiis.Professional/ → now 5-Aquiis.Professional/ - Aquiis.SimpleStart/ → now 4-Aquiis.SimpleStart/ - Aquiis.*Tests/ → now in 6-Tests/ Solution file already references only numbered directories.
xnodeoncode
added
🔧 enhancement
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive Shared UI library and workflow infrastructure for the Aquiis property management application, enabling safe divergence of product development while maintaining common components.
Changes:
- Implemented workflow state machine pattern with base workflow services for managing entity lifecycle transitions
- Added application and lease workflow services with full state management, validation, and audit logging
- Created multiple business service layers including tour, tenant, payment, and security deposit management
- Added PDF generation capabilities for various documents (invoices, leases, inspections, financial reports)
- Implemented notification, SMS, and organization management services
Reviewed changes
Copilot reviewed 110 out of 1461 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IWorkflowState.cs | Interface defining workflow state machine operations |
| BaseWorkflowService.cs | Base class providing transaction support and audit logging for workflows |
| ApplicationWorkflowService.cs | Comprehensive rental application lifecycle management from submission through lease acceptance |
| AccountWorkflowService.cs | Stub implementation for account workflow state transitions |
| TourService.cs | Property tour scheduling and management with checklist integration |
| TenantService.cs | Tenant CRUD operations with validation and relationship management |
| TenantConversionService.cs | Converts prospects to tenants during lease signing |
| SecurityDepositService.cs | Security deposit lifecycle including investment pool and dividend distribution |
| ScreeningService.cs | Application screening management with background/credit check tracking |
| SchemaValidationService.cs | Database schema version validation and management |
| ScheduledTaskService.cs | Background service for automated tasks (late fees, expiration, reminders) |
| SMSSettingsService.cs | SMS configuration and Twilio integration management |
| SMSService.cs | SMS sending and statistics tracking |
| RentalApplicationService.cs | Rental application CRUD with validation and status management |
| ProspectiveTenantService.cs | Prospective tenant management and status tracking |
| PropertyService.cs | Property CRUD with inspection scheduling and occupancy tracking |
| PaymentPdfGenerator.cs | PDF generation for payment receipts |
| LeaseRenewalPdfGenerator.cs | PDF generation for lease renewal offers |
| LeasePdfGenerator.cs | PDF generation for lease agreements |
| InvoicePdfGenerator.cs | PDF generation for invoices |
| InspectionPdfGenerator.cs | PDF generation for inspection reports |
| FinancialReportPdfGenerator.cs | PDF generation for financial reports (income statements, rent roll, tax reports) |
| ChecklistPdfGenerator.cs | PDF generation for checklists |
| PaymentService.cs | Payment CRUD with automatic invoice status updates |
| OrganizationService.cs | Organization and user-organization relationship management |
| NotificationService.cs | Multi-channel notification delivery (in-app, email, SMS) |
| NoteService.cs | Entity-linked note management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated test path from Aquiis.SimpleStart.Tests to 6-Tests/Aquiis.Application.Tests to reflect the new numbered directory organization.
- Test Core layer (6-Tests/Aquiis.Core.Tests) - Test Application layer (6-Tests/Aquiis.Application.Tests) - Test Shared UI components with bUnit (6-Tests/Aquiis.UI.Shared.Tests) - Omit Infrastructure tests (no tests yet) and Playwright UI tests (require running apps)
xskcdf
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared UI Implementation complete. Product development can now diverge safely with the Shared UI library being the home for common components.