Skip to content

Update Bascule to v1#554

Open
renaz6 wants to merge 4 commits into
mainfrom
updateBascule
Open

Update Bascule to v1#554
renaz6 wants to merge 4 commits into
mainfrom
updateBascule

Conversation

@renaz6
Copy link
Copy Markdown
Member

@renaz6 renaz6 commented May 27, 2026

Closes https://github.com/comcast-cl/xmidt/issues/6451

  • Migrates to Bascule v1.1.1 and updates validation flows to the v1 patterns.
  • Removes reliance on deprecated Bascule helpers/check packages
  • Adds new JWT/basic parser logic

Comment thread .github/workflows/proj-xmidt-team.yml Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 32.86219% with 190 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.14%. Comparing base (f97ed48) to head (744cec7).

Files with missing lines Patch % Lines
primaryHandler.go 0.00% 124 Missing ⚠️
auth_parsers.go 59.23% 51 Missing and 2 partials ⚠️
metrics.go 0.00% 7 Missing ⚠️
WRPAccessControl.go 58.33% 4 Missing and 1 partial ⚠️
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   21.36%   26.14%   +4.78%     
==========================================
  Files           7        8       +1     
  Lines         571      784     +213     
==========================================
+ Hits          122      205      +83     
- Misses        447      574     +127     
- Partials        2        5       +3     
Flag Coverage Δ
unittests 26.14% <32.86%> (+4.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renaz6 renaz6 requested review from johnabass and schmidtw May 29, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants