Add video/audio bitrate stats and RTT measurement for RTMP streaming#1
Open
Add video/audio bitrate stats and RTT measurement for RTMP streaming#1
Conversation
Co-authored-by: xiuminga <35331382+xiuminga@users.noreply.github.com>
Co-authored-by: xiuminga <35331382+xiuminga@users.noreply.github.com>
Co-authored-by: xiuminga <35331382+xiuminga@users.noreply.github.com>
Co-authored-by: xiuminga <35331382+xiuminga@users.noreply.github.com>
Co-authored-by: xiuminga <35331382+xiuminga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add independent video/audio bitrate stats and RTT measurement
Add video/audio bitrate stats and RTT measurement for RTMP streaming
Dec 18, 2025
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds separate video/audio bitrate tracking and RTT measurement using RTMP User Control ping-pong messages.
Changes
BaseSender.kt
videoBytesSendPerSecondandaudioBytesSendPerSecondseparatelygetVideoBitrate()andgetAudioBitrate()returning bits/secresetBytesSend()RtmpSender.kt
onRun()based on packet typeCommandsManager.kt
sendPing(sequence, socket)for RTMP PING_REQUESTRtmpClient.kt
getRtt()/getAverageRtt()for current and average RTT (ms)measureRtt()triggers ping,resetRtt()clears historygetVideoBitrate()/getAudioBitrate()from senderRtmpStreamClient.kt
Usage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.3-bin/cv11ve7ro1n3o1j4so8xd9n66/gradle-8.14.3/lib/gradle-daemon-main-8.14.3.jar(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.