Skip to content

adding in some tiny modifications that allow cosmic-pop to run #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xevra merged 1 commit into from
Apr 7, 2026
Merged

adding in some tiny modifications that allow cosmic-pop to run #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/cosmic-pop
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def parse_commandline():
" to select the subpopulation of interest from the evolved population")
parser.add_argument("--match", type=float, help="provides the tolerance for the convergence calculation")
parser.add_argument("--apply_convergence_limits", type=str2bool, nargs='?',
const=True, default=False, help="filters the evolved binary population to contain"
const=True, help="filters the evolved binary population to contain"
" only the binaries that satsify the convergence limits")
parser.add_argument("--seed", type=int)
parser.add_argument("--verbose", action="store_true", default=False,
Expand Down
2 changes: 1 addition & 1 deletion src/cosmic/sample/sampler/independent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def get_independent_sampler(

# sample periods and eccentricities
# if the porb_model is moe19, the metallicity needs to be supplied
if porb_model == "moe19":
if porb_model in ["moe19", "martinez26", "martinez26_ecsn"]:
porb,aRL_over_a = initconditions.sample_porb(
mass1_binary, mass2_binary, rad1, rad2, porb_model, met=met, size=mass1_binary.size
)
Expand Down
Loading