Skip to content

Fix contours() docstring overstating Dask peak-memory guarantee #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendancol merged 3 commits into from
Jun 3, 2026
+5 −2
Merged

Fix contours() docstring overstating Dask peak-memory guarantee #2906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c524aae
Fix contours() docstring overstating Dask peak-memory guarantee
Melissari1997 Jun 3, 2026
56022bc
test(contour): remove docstring wording regression test
Melissari1997 Jun 3, 2026
e99e740
refactor(contour): replace itertools.chain with list extension in das…
Melissari1997 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions xrspatial/contour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,10 @@ def contours(
CuPy and Dask+CuPy arrays are accepted as input. Data is
transferred to CPU for the tracing step because segment stitching
is an inherently sequential graph traversal. For Dask inputs,
each chunk is processed independently and results are merged,
keeping peak memory proportional to chunk size.
chunking bounds the per-chunk scan buffers, but the global merge
step materializes all contour segments at once to stitch polylines
across chunk boundaries, so peak memory scales with total contour
complexity rather than chunk size.

Examples
--------
Expand Down
1 change: 1 addition & 0 deletions xrspatial/tests/test_contour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,3 +756,4 @@ def test_lat_lon_matches_yx_equivalent(self):
for (lvl_a, c_a), (lvl_b, c_b) in zip(r_yx, r_ll):
assert lvl_a == lvl_b
np.testing.assert_allclose(c_a, c_b)

Loading