CP-310956: Remove legacy winbind configuration #6822
Conversation
|
232236 (Dev Run) Authentication sanity test looks good. |
liulinC
force-pushed
the
private/linl/dev
branch
from
7ef47bb to
7d443a5
Compare
liulinC
changed the title
9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility. Now samba binary is updated in all releases, this commit just drop the legacy configurations Signed-off-by: Lin Liu <lin.liu01@citrix.com>
liulinC
force-pushed
the
private/linl/dev
branch
from
7d443a5 to
2f7d1fe
Compare
|
Note: xcp-ng still hasn't updated to samba 4.20, this means that samba needs to be updated before this change is adapted in xcp-ng |
| ; "" (* Empty line at the end *) | ||
| ] | ||
| [ | ||
| "# autogenerated by xapi" |
There was a problem hiding this comment.
Do we want to change it to:
# autogenerated by xapi
# do not change because changes will be overwritten"
There was a problem hiding this comment.
does't autogenerated by xapi already indicate changes will be overwritten? and we do expect customer to change it and restart winbind temporary for debug purpose.
do we have an estimation about when it be done? |
I don't think we need to wait to merge this, just to be aware of it, are you planning to add a dependency in the .spec file? |
|
I'm not fond of a XAPI update enforcing a samba upgrade on a maintenance release of XCP-ng. I need to better understand why this change absolutely needs to be merged prior to branching off the maintenance branch of XS 8.4+XCP-ng 8.3. |
|
@stormi , I agree in principle, but this particular update was needed to address a serious issue for Window VMs. See the linked commit 9a468bf and https://bugzilla.samba.org/show_bug.cgi?id=15876. |
5 participants
9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility.
Now samba binary is updated in all releases, this commit just drop the legacy configurations